Add clang-tidy support by alan-george-lk · Pull Request #97 · livekit/client-sdk-cpp

alan-george-lk · 2026-04-15T18:42:04Z

This PR adds support for clang-tidy static analysis within the CI. The list of initial checks can be found in the .clang-tidy file at the root of the repository.

Fixes to .h/.cpp files flagged by the analysis were also done.

…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…/clang-tidy

…ptimize clang-tidy run

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Have any feedback or feature suggestions? Share it here.

…/clang-tidy

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Click here for the full clang-tidy patch

diff --git a/src/audio_stream.cpp b/src/audio_stream.cpp
index ef9263c..6ec0150 100644
--- a/src/audio_stream.cpp
+++ b/src/audio_stream.cpp
@@ -216 +216 @@ void AudioStream::onFfiEvent(const FfiEvent &event) {
-    AudioFrameEvent ev{std::move(frame)};
+    AudioFrameEvent ev{frame};
diff --git a/src/rpc_error.cpp b/src/rpc_error.cpp
index 1e521cd..96848ee 100644
--- a/src/rpc_error.cpp
+++ b/src/rpc_error.cpp
@@ -52 +52 @@ RpcError RpcError::fromProto(const proto::RpcError &err) {
-  return RpcError(err.code(), err.message(), err.data());
+  return {err.code(), err.message(), err.data()};
@@ -57 +57 @@ RpcError RpcError::builtIn(ErrorCode code, const std::string &data) {
-  return RpcError(code, msg ? std::string(msg) : std::string{}, data);
+  return {code, msg ? std::string(msg) : std::string{}, data};
diff --git a/src/room.cpp b/src/room.cpp
index f4ffd74..e6375d3 100644
--- a/src/room.cpp
+++ b/src/room.cpp
@@ -300 +300 @@ void Room::setOnVideoFrameCallback(const std::string &participant_identity,
-        participant_identity, source, std::move(callback), std::move(opts));
+        participant_identity, source, std::move(callback), opts);
@@ -310 +310 @@ void Room::setOnVideoFrameCallback(const std::string &participant_identity,
-        participant_identity, track_name, std::move(callback), std::move(opts));
+        participant_identity, track_name, std::move(callback), opts);
diff --git a/src/video_frame.cpp b/src/video_frame.cpp
index 870dfee..63a30b3 100644
--- a/src/video_frame.cpp
+++ b/src/video_frame.cpp
@@ -298 +298 @@ VideoFrame VideoFrame::create(int width, int height, VideoBufferType type) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
@@ -306 +306 @@ std::vector<VideoPlaneInfo> VideoFrame::planeInfos() const {
-  uintptr_t base = reinterpret_cast<uintptr_t>(data_.data());
+  auto base = reinterpret_cast<uintptr_t>(data_.data());
@@ -318 +318 @@ VideoFrame VideoFrame::convert(VideoBufferType dst, bool flip_y) const {
-    return VideoFrame(width_, height_, type_, std::move(buf));
+    return {width_, height_, type_, std::move(buf)};
@@ -376 +376 @@ VideoFrame VideoFrame::fromOwnedInfo(const proto::OwnedVideoBuffer &owned) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
diff --git a/src/data_stream.cpp b/src/data_stream.cpp
index 70d871a..4117e0d 100644
--- a/src/data_stream.cpp
+++ b/src/data_stream.cpp
@@ -22,0 +23 @@
+#include <utility>
@@ -107 +108 @@ void fillBaseInfo(BaseStreamInfo &dst, const std::string &stream_id,
-TextStreamReader::TextStreamReader(const TextStreamInfo &info) : info_(info) {}
+TextStreamReader::TextStreamReader(TextStreamInfo info) : info_(std::move(info)) {}
@@ -151 +152 @@ std::string TextStreamReader::readAll() {
-ByteStreamReader::ByteStreamReader(const ByteStreamInfo &info) : info_(info) {}
+ByteStreamReader::ByteStreamReader(ByteStreamInfo info) : info_(std::move(info)) {}
@@ -192 +193 @@ BaseStreamWriter::BaseStreamWriter(
-    LocalParticipant &local_participant, const std::string &topic,
+    LocalParticipant &local_participant, std::string topic,
@@ -195 +196 @@ BaseStreamWriter::BaseStreamWriter(
-    const std::string &mime_type,
+    std::string mime_type,
@@ -197 +198 @@ BaseStreamWriter::BaseStreamWriter(
-    const std::string &sender_identity)
+    std::string sender_identity)
@@ -200 +201 @@ BaseStreamWriter::BaseStreamWriter(
-      mime_type_(mime_type), topic_(topic),
+      mime_type_(std::move(mime_type)), topic_(std::move(topic)),
@@ -206 +207 @@ BaseStreamWriter::BaseStreamWriter(
-      sender_identity_(sender_identity) {
+      sender_identity_(std::move(sender_identity)) {
diff --git a/src/subscription_thread_dispatcher.cpp b/src/subscription_thread_dispatcher.cpp
index ee68365..7c548e8 100644
--- a/src/subscription_thread_dispatcher.cpp
+++ b/src/subscription_thread_dispatcher.cpp
@@ -90 +90 @@ void SubscriptionThreadDispatcher::setOnVideoFrameCallback(
-      RegisteredVideoCallback{std::move(callback), std::move(opts)};
+      RegisteredVideoCallback{std::move(callback), opts};
@@ -105 +105 @@ void SubscriptionThreadDispatcher::setOnVideoFrameCallback(
-      RegisteredVideoCallback{std::move(callback), std::move(opts)};
+      RegisteredVideoCallback{std::move(callback), opts};
@@ -478 +478 @@ std::thread SubscriptionThreadDispatcher::startAudioReaderLocked(
-    AudioFrameCallback cb, const AudioStream::Options &opts) {
+    const AudioFrameCallback& cb, const AudioStream::Options &opts) {
@@ -501 +501 @@ std::thread SubscriptionThreadDispatcher::startAudioReaderLocked(
-  auto stream_copy = stream;
+  const auto& stream_copy = stream;
@@ -529 +529 @@ std::thread SubscriptionThreadDispatcher::startVideoReaderLocked(
-    VideoFrameCallback cb, const VideoStream::Options &opts) {
+    const VideoFrameCallback& cb, const VideoStream::Options &opts) {
@@ -552 +552 @@ std::thread SubscriptionThreadDispatcher::startVideoReaderLocked(
-  auto stream_copy = stream;
+  const auto& stream_copy = stream;
@@ -623 +623 @@ std::thread SubscriptionThreadDispatcher::startDataReaderLocked(
-    const std::shared_ptr<RemoteDataTrack> &track, DataFrameCallback cb) {
+    const std::shared_ptr<RemoteDataTrack> &track, const DataFrameCallback& cb) {
diff --git a/src/audio_frame.cpp b/src/audio_frame.cpp
index 23ff01e..5d58f6e 100644
--- a/src/audio_frame.cpp
+++ b/src/audio_frame.cpp
@@ -57,2 +57,2 @@ AudioFrame AudioFrame::create(int sample_rate, int num_channels,
-  return AudioFrame(std::move(data), sample_rate, num_channels,
-                    samples_per_channel);
+  return {std::move(data), sample_rate, num_channels,
+                    samples_per_channel};
@@ -72 +72 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
-  const std::int16_t *ptr =
+  const auto *ptr =
@@ -91,2 +91,2 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
-  return AudioFrame(std::move(data), sample_rate, num_channels,
-                    samples_per_channel);
+  return {std::move(data), sample_rate, num_channels,
+                    samples_per_channel};

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Click here for the full clang-tidy patch

diff --git a/src/audio_frame.cpp b/src/audio_frame.cpp
index 23ff01e..5d58f6e 100644
--- a/src/audio_frame.cpp
+++ b/src/audio_frame.cpp
@@ -57,2 +57,2 @@ AudioFrame AudioFrame::create(int sample_rate, int num_channels,
-  return AudioFrame(std::move(data), sample_rate, num_channels,
-                    samples_per_channel);
+  return {std::move(data), sample_rate, num_channels,
+                    samples_per_channel};
@@ -72 +72 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
-  const std::int16_t *ptr =
+  const auto *ptr =
@@ -91,2 +91,2 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
-  return AudioFrame(std::move(data), sample_rate, num_channels,
-                    samples_per_channel);
+  return {std::move(data), sample_rate, num_channels,
+                    samples_per_channel};
diff --git a/src/data_stream.cpp b/src/data_stream.cpp
index 70d871a..4117e0d 100644
--- a/src/data_stream.cpp
+++ b/src/data_stream.cpp
@@ -22,0 +23 @@
+#include <utility>
@@ -107 +108 @@ void fillBaseInfo(BaseStreamInfo &dst, const std::string &stream_id,
-TextStreamReader::TextStreamReader(const TextStreamInfo &info) : info_(info) {}
+TextStreamReader::TextStreamReader(TextStreamInfo info) : info_(std::move(info)) {}
@@ -151 +152 @@ std::string TextStreamReader::readAll() {
-ByteStreamReader::ByteStreamReader(const ByteStreamInfo &info) : info_(info) {}
+ByteStreamReader::ByteStreamReader(ByteStreamInfo info) : info_(std::move(info)) {}
@@ -192 +193 @@ BaseStreamWriter::BaseStreamWriter(
-    LocalParticipant &local_participant, const std::string &topic,
+    LocalParticipant &local_participant, std::string topic,
@@ -195 +196 @@ BaseStreamWriter::BaseStreamWriter(
-    const std::string &mime_type,
+    std::string mime_type,
@@ -197 +198 @@ BaseStreamWriter::BaseStreamWriter(
-    const std::string &sender_identity)
+    std::string sender_identity)
@@ -200 +201 @@ BaseStreamWriter::BaseStreamWriter(
-      mime_type_(mime_type), topic_(topic),
+      mime_type_(std::move(mime_type)), topic_(std::move(topic)),
@@ -206 +207 @@ BaseStreamWriter::BaseStreamWriter(
-      sender_identity_(sender_identity) {
+      sender_identity_(std::move(sender_identity)) {
diff --git a/src/video_frame.cpp b/src/video_frame.cpp
index 870dfee..63a30b3 100644
--- a/src/video_frame.cpp
+++ b/src/video_frame.cpp
@@ -298 +298 @@ VideoFrame VideoFrame::create(int width, int height, VideoBufferType type) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
@@ -306 +306 @@ std::vector<VideoPlaneInfo> VideoFrame::planeInfos() const {
-  uintptr_t base = reinterpret_cast<uintptr_t>(data_.data());
+  auto base = reinterpret_cast<uintptr_t>(data_.data());
@@ -318 +318 @@ VideoFrame VideoFrame::convert(VideoBufferType dst, bool flip_y) const {
-    return VideoFrame(width_, height_, type_, std::move(buf));
+    return {width_, height_, type_, std::move(buf)};
@@ -376 +376 @@ VideoFrame VideoFrame::fromOwnedInfo(const proto::OwnedVideoBuffer &owned) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
diff --git a/src/subscription_thread_dispatcher.cpp b/src/subscription_thread_dispatcher.cpp
index ee68365..7c548e8 100644
--- a/src/subscription_thread_dispatcher.cpp
+++ b/src/subscription_thread_dispatcher.cpp
@@ -90 +90 @@ void SubscriptionThreadDispatcher::setOnVideoFrameCallback(
-      RegisteredVideoCallback{std::move(callback), std::move(opts)};
+      RegisteredVideoCallback{std::move(callback), opts};
@@ -105 +105 @@ void SubscriptionThreadDispatcher::setOnVideoFrameCallback(
-      RegisteredVideoCallback{std::move(callback), std::move(opts)};
+      RegisteredVideoCallback{std::move(callback), opts};
@@ -478 +478 @@ std::thread SubscriptionThreadDispatcher::startAudioReaderLocked(
-    AudioFrameCallback cb, const AudioStream::Options &opts) {
+    const AudioFrameCallback& cb, const AudioStream::Options &opts) {
@@ -501 +501 @@ std::thread SubscriptionThreadDispatcher::startAudioReaderLocked(
-  auto stream_copy = stream;
+  const auto& stream_copy = stream;
@@ -529 +529 @@ std::thread SubscriptionThreadDispatcher::startVideoReaderLocked(
-    VideoFrameCallback cb, const VideoStream::Options &opts) {
+    const VideoFrameCallback& cb, const VideoStream::Options &opts) {
@@ -552 +552 @@ std::thread SubscriptionThreadDispatcher::startVideoReaderLocked(
-  auto stream_copy = stream;
+  const auto& stream_copy = stream;
@@ -623 +623 @@ std::thread SubscriptionThreadDispatcher::startDataReaderLocked(
-    const std::shared_ptr<RemoteDataTrack> &track, DataFrameCallback cb) {
+    const std::shared_ptr<RemoteDataTrack> &track, const DataFrameCallback& cb) {

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Click here for the full clang-tidy patch

diff --git a/src/subscription_thread_dispatcher.cpp b/src/subscription_thread_dispatcher.cpp
index ee68365..7c548e8 100644
--- a/src/subscription_thread_dispatcher.cpp
+++ b/src/subscription_thread_dispatcher.cpp
@@ -90 +90 @@ void SubscriptionThreadDispatcher::setOnVideoFrameCallback(
-      RegisteredVideoCallback{std::move(callback), std::move(opts)};
+      RegisteredVideoCallback{std::move(callback), opts};
@@ -105 +105 @@ void SubscriptionThreadDispatcher::setOnVideoFrameCallback(
-      RegisteredVideoCallback{std::move(callback), std::move(opts)};
+      RegisteredVideoCallback{std::move(callback), opts};
@@ -478 +478 @@ std::thread SubscriptionThreadDispatcher::startAudioReaderLocked(
-    AudioFrameCallback cb, const AudioStream::Options &opts) {
+    const AudioFrameCallback& cb, const AudioStream::Options &opts) {
@@ -501 +501 @@ std::thread SubscriptionThreadDispatcher::startAudioReaderLocked(
-  auto stream_copy = stream;
+  const auto& stream_copy = stream;
@@ -529 +529 @@ std::thread SubscriptionThreadDispatcher::startVideoReaderLocked(
-    VideoFrameCallback cb, const VideoStream::Options &opts) {
+    const VideoFrameCallback& cb, const VideoStream::Options &opts) {
@@ -552 +552 @@ std::thread SubscriptionThreadDispatcher::startVideoReaderLocked(
-  auto stream_copy = stream;
+  const auto& stream_copy = stream;
@@ -623 +623 @@ std::thread SubscriptionThreadDispatcher::startDataReaderLocked(
-    const std::shared_ptr<RemoteDataTrack> &track, DataFrameCallback cb) {
+    const std::shared_ptr<RemoteDataTrack> &track, const DataFrameCallback& cb) {
diff --git a/src/video_frame.cpp b/src/video_frame.cpp
index 870dfee..63a30b3 100644
--- a/src/video_frame.cpp
+++ b/src/video_frame.cpp
@@ -298 +298 @@ VideoFrame VideoFrame::create(int width, int height, VideoBufferType type) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
@@ -306 +306 @@ std::vector<VideoPlaneInfo> VideoFrame::planeInfos() const {
-  uintptr_t base = reinterpret_cast<uintptr_t>(data_.data());
+  auto base = reinterpret_cast<uintptr_t>(data_.data());
@@ -318 +318 @@ VideoFrame VideoFrame::convert(VideoBufferType dst, bool flip_y) const {
-    return VideoFrame(width_, height_, type_, std::move(buf));
+    return {width_, height_, type_, std::move(buf)};
@@ -376 +376 @@ VideoFrame VideoFrame::fromOwnedInfo(const proto::OwnedVideoBuffer &owned) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};

Have any feedback or feature suggestions? Share it here.

…/clang-tidy

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Click here for the full clang-tidy patch

diff --git a/src/video_frame.cpp b/src/video_frame.cpp
index 870dfee..63a30b3 100644
--- a/src/video_frame.cpp
+++ b/src/video_frame.cpp
@@ -298 +298 @@ VideoFrame VideoFrame::create(int width, int height, VideoBufferType type) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
@@ -306 +306 @@ std::vector<VideoPlaneInfo> VideoFrame::planeInfos() const {
-  uintptr_t base = reinterpret_cast<uintptr_t>(data_.data());
+  auto base = reinterpret_cast<uintptr_t>(data_.data());
@@ -318 +318 @@ VideoFrame VideoFrame::convert(VideoBufferType dst, bool flip_y) const {
-    return VideoFrame(width_, height_, type_, std::move(buf));
+    return {width_, height_, type_, std::move(buf)};
@@ -376 +376 @@ VideoFrame VideoFrame::fromOwnedInfo(const proto::OwnedVideoBuffer &owned) {
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
diff --git a/src/trace/event_tracer.cpp b/src/trace/event_tracer.cpp
index 8809993..3340f00 100644
--- a/src/trace/event_tracer.cpp
+++ b/src/trace/event_tracer.cpp
@@ -40,2 +40,2 @@
-namespace livekit {
-namespace trace {
+
+namespace livekit::trace {
@@ -179,3 +179,3 @@ std::string FormatEventJson(const TraceEventData &event, uint64_t start_time) {
-  oss << "\"ph\":\"" << event.phase << "\",";
-  oss << "\"cat\":\"" << JsonEscape(event.category) << "\",";
-  oss << "\"name\":\"" << JsonEscape(event.name) << "\",";
+  oss << R"("ph":")" << event.phase << "\",";
+  oss << R"("cat":")" << JsonEscape(event.category) << "\",";
+  oss << R"("name":")" << JsonEscape(event.name) << "\",";
@@ -187 +187 @@ std::string FormatEventJson(const TraceEventData &event, uint64_t start_time) {
-    oss << ",\"id\":\"0x" << std::hex << event.id << std::dec << "\"";
+    oss << R"(,"id":"0x)" << std::hex << event.id << std::dec << "\"";
@@ -430 +430 @@ void StopTracing() {
-    g_trace_file << "],\"displayTimeUnit\":\"ms\"}";
+    g_trace_file << R"(],"displayTimeUnit":"ms"})";
@@ -444,2 +444,2 @@ bool IsTracingEnabled() {
-} // namespace trace
-} // namespace livekit
+} // namespace livekit::trace
+

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v20.1.2

Click here for the full clang-tidy patch

diff --git a/src/trace/event_tracer.cpp b/src/trace/event_tracer.cpp
index 8809993..3340f00 100644
--- a/src/trace/event_tracer.cpp
+++ b/src/trace/event_tracer.cpp
@@ -40,2 +40,2 @@
-namespace livekit {
-namespace trace {
+
+namespace livekit::trace {
@@ -179,3 +179,3 @@ std::string FormatEventJson(const TraceEventData &event, uint64_t start_time) {
-  oss << "\"ph\":\"" << event.phase << "\",";
-  oss << "\"cat\":\"" << JsonEscape(event.category) << "\",";
-  oss << "\"name\":\"" << JsonEscape(event.name) << "\",";
+  oss << R"("ph":")" << event.phase << "\",";
+  oss << R"("cat":")" << JsonEscape(event.category) << "\",";
+  oss << R"("name":")" << JsonEscape(event.name) << "\",";
@@ -187 +187 @@ std::string FormatEventJson(const TraceEventData &event, uint64_t start_time) {
-    oss << ",\"id\":\"0x" << std::hex << event.id << std::dec << "\"";
+    oss << R"(,"id":"0x)" << std::hex << event.id << std::dec << "\"";
@@ -430 +430 @@ void StopTracing() {
-    g_trace_file << "],\"displayTimeUnit\":\"ms\"}";
+    g_trace_file << R"(],"displayTimeUnit":"ms"})";
@@ -444,2 +444,2 @@ bool IsTracingEnabled() {
-} // namespace trace
-} // namespace livekit
+} // namespace livekit::trace
+

Have any feedback or feature suggestions? Share it here.

…/clang-tidy

xianshijing-lk · 2026-04-17T16:14:01Z

  case proto::KIND_LOSSY:
    return DataPacketKind::Lossy;
  case proto::KIND_RELIABLE:
-    return DataPacketKind::Reliable;


can we remove the default instead ? that will allow us to catch the problem in compilation

xianshijing-lk · 2026-04-17T16:20:48Z


  // Listener id registered on FfiClient
-  std::int64_t listener_id_{0};
+  std::int32_t listener_id_{0};


Is this change intentional ?
Didn't you mention that you would like to change the listener id to int64_t ?

This was intentional: our options are to move this to int64_t:

client-sdk-cpp/src/ffi_client.h

Line 68 in e69c646

using ListenerId = int;

Or adjust the other listener ID types internally.

I opted for the latter option, because ffi_client.h and this typedef are public API, the other instances in the streams are private member variables. Open to discussion

xianshijing-lk · 2026-04-17T16:36:06Z

+      fi
+    fi
+    ;;
+  debug-all)


are these changes belonging to this clang-tidy PR ?

Or you need to rebase ?

Intentional: the release-all is now used to build the code and tests for clang-tidy parsing, the debug-all is just to have feature parity on our build options

stephen-derosa

in general this looks good, thanks for doing! I have some questions/comments, nothing major

stephen-derosa · 2026-04-17T16:29:33Z

+          submodules: recursive
+          fetch-depth: 1
+
+      - name: Install dependencies


holy deps of clang, im surprised there isnt a clanh-tidy ez unstall

I might be able to clean this up -- standby

stephen-derosa · 2026-04-17T16:35:47Z


  // Listener id registered on FfiClient
-  std::int64_t listener_id_{0};
+  std::int32_t listener_id_{0};


why are we reducing size here?

ffi returns a int32_t?

See this comment: #97 (comment)

alan-george-lk and others added 30 commits April 9, 2026 13:32

Add clang-tidy in GHA CI

5e5a41b

Potential fix for pull request finding 'CodeQL / Workflow does not co…

5e2268f

…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Remove compile commands

a584b27

Possibly fix pathing

918a2c0

Rebase and optimize build for debugging

e65e8ab

Debugging clang stage

99081ab

Remove debug output

36e9110

Try cpplinter stage instead

85caa49

Hopefully fix clang issue

cce7d8b

Add github token

cccbc74

Turn files changed only off

72c2fe4

New clang-tidy error list for the critical stuff

8aa951d

Adjustments to clang-tidy checks

65d923e

Fix one introduce another

45b9e5b

Cleanup clang file

357b85f

Revert bridge_audio_track change that induced clang-tidy

be4d8a4

Modernize namespaces

13e9948

Merge branch 'main' of github.com:livekit/client-sdk-cpp into feature…

3fbacd1

…/clang-tidy

Fix two clang issues

695a242

Use all possible cores on clang-tidy

d55804a

Use Node24 versions of things

808f781

build improvements: *-all build configs, ccache, configure stage to o…

648f4b0

…ptimize clang-tidy run

Attempt to fix diagnostic clang errors

afba69d

Cleaner compile database

f242a9d

Some bugprone fixes

9561293

Additional fixes

a9ff299

Hopefully cleaner run

c977e81

Ignore tests folder

2512840

Turn on all stages again

f3be562

Undo ccache, additional clang-tidy fixes

67a990b

github-actions bot reviewed Apr 15, 2026

View reviewed changes

livekit deleted a comment from github-actions bot Apr 15, 2026

Additional fixes

5a83949

github-actions bot reviewed Apr 15, 2026

View reviewed changes

alan-george-lk added 3 commits April 15, 2026 16:59

Fix empty catch

3bc0acb

Try latest clang folder paths for diagnostic issues

5abfda7

Merge branch 'main' of github.com:livekit/client-sdk-cpp into feature…

4edfe8e

…/clang-tidy

github-actions bot reviewed Apr 15, 2026

View reviewed changes

Additional clang-tidy checks

ccc021f

livekit deleted a comment from github-actions bot Apr 16, 2026

github-actions bot reviewed Apr 16, 2026

View reviewed changes

Additional clang-tidy changes

8bcea38

github-actions bot reviewed Apr 16, 2026

View reviewed changes

alan-george-lk added 2 commits April 16, 2026 10:08

Additional clang-tidy fixes

724e1af

Merge branch 'main' of github.com:livekit/client-sdk-cpp into feature…

8c62f8d

…/clang-tidy

github-actions bot reviewed Apr 16, 2026

View reviewed changes

Additional clang-tidy fixes, 0 warning threshold

6ec2a43

github-actions bot reviewed Apr 16, 2026

View reviewed changes

alan-george-lk added 2 commits April 16, 2026 12:54

More fixes

b5cee08

Merge branch 'main' of github.com:livekit/client-sdk-cpp into feature…

a20e07e

…/clang-tidy

alan-george-lk changed the title ~~Draft v2 - Add clang-tidy support~~ Add clang-tidy support Apr 17, 2026

Remove separate configure stage

8747546

xianshijing-lk reviewed Apr 17, 2026

View reviewed changes

stephen-derosa reviewed Apr 17, 2026

View reviewed changes

alan-george-lk added 2 commits April 17, 2026 15:22

Add readme on clang tools

0bdfb3e

PR feedback and integration test updates for env var

10b5216

Conversation

alan-george-lk commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v20.1.2

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-george-lk Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephen-derosa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alan-george-lk commented Apr 15, 2026 •

edited

Loading

alan-george-lk Apr 17, 2026 •

edited

Loading